Skip to content

Update tour.md due to "Try F# in Fable" link leads to a non-functioni… #36388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update tour.md due to "Try F# in Fable" link leads to a non-functioni… #36388

merged 1 commit into from
Jul 26, 2023

Conversation

@Sljcom
Copy link
Contributor

@Sljcom Sljcom commented Jul 25, 2023 •
edited by github-actions bot
Loading

…ng playground

Changed the link to direct users to the working playground as shown in fable.io homepage

Summary

Simply removed the 3 in the Fable link to direct users to a working playground.
The current link leads to an identical playground, but there are errors with the playground that prevents code from running.

Error messages in Console

[FABLE WORKER] Cannot decode: Error at: `$`
The following `failure` occurred with the decoder: Expected 3 union fields but got 2

workbox-d9851aed.js:1 Uncaught (in promise) bad-precaching-response: bad-precaching-response :: [{"url":"https://fable.io/repl3/js/repl/fable-library/.fable/compiler_info.txt","status":404}]
    at y.u (https://fable.io/repl3/workbox-d9851aed.js:1:5420)
    at async Promise.all (index 1)
    at async y.install (https://fable.io/repl3/workbox-d9851aed.js:1:4833)

Fixes #Issue_Number (if available)

Internal previews

📄 File 🔗 Preview link
docs/fsharp/tour.md Tour of F#

@Sljcom
Update tour.md due to "Try F# in Fable" link leads to a non-functioni…
f7a9c8f 
…ng playground

Changed the link to direct users to the working playground as shown in fable.io homepage
@Sljcom Sljcom requested review from a team and KathleenDollard as code owners July 25, 2023 18:55
@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 25, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 25, 2023
@BillWagner
Copy link
Member

closing and reopening for a fresh CI build.

@BillWagner BillWagner closed this Jul 26, 2023
@BillWagner BillWagner reopened this Jul 26, 2023
BillWagner
BillWagner approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sljcom

This is great, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) July 26, 2023 17:07
@BillWagner BillWagner merged commit 43e159e into dotnet:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc

Projects

None yet

Milestone

July 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@Sljcom @BillWagner @dotnet-bot